Abstract: A sound classification of petroleum pools must be scientific and practical: scientific in the sense that the classification is based on the trap forming elements and can reflect the differences and relationship between the traps; and practical in the sense that the classification is simple and clear that can very well serve as a guide for oil and gas exploration. On the basis of the above two criteria, the author proposes to divide the petroleum traps broadly into two basic types: structural and stratigraphic. Based on their specific origin and apparent features, structural pools are further classified into four sub-groups: anticlinal pools; and pools caused by faulting, fracturing and piercement folding. Stratigraphic pools are subdivided into lithologic, stratigraphic unconformity, stratigraphic overlap and bioherm pools. The main types of oil pools in China are examined in the examples and also in the conclusion.